Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry Clang Check readability-avoid-const-params-in-decls #20251

Merged
merged 4 commits into from Aug 28, 2017
Merged

Geometry Clang Check readability-avoid-const-params-in-decls #20251

merged 4 commits into from Aug 28, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 24, 2017

@ianna
Geometry Clang readability-avoid-const-params-in-decls
016b5ce
@ianna
Merged geom-readability-avoid-const-params-in-decls from repository i…
5420001 
…anna with cms-merge-topic

Conflicts:
	Geometry/EcalCommonData/interface/DDEcalBarrelAlgo.h
	Geometry/EcalCommonData/interface/DDEcalBarrelNewAlgo.h
	Geometry/HGCalCommonData/interface/HGCalDDDConstants.h
	Geometry/MuonNumbering/interface/MuonBaseNumber.h
	Geometry/VeryForwardGeometryBuilder/plugins/CTPPSIncludeAlignments.cc
@ianna
Copy link
Contributor Author

ianna commented Aug 24, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Aug 24, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22460/console Started: 2017/08/24 10:54

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/CommonDetUnit
Geometry/CommonTopologies
Geometry/DTGeometryBuilder
Geometry/EcalCommonData
Geometry/EcalTestBeam
Geometry/HGCalCommonData
Geometry/HcalCommonData
Geometry/HcalTowerAlgo
Geometry/MuonNumbering
Geometry/TrackerGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @argiro, @ptcox, @ebrondol, @VinInn, @venturia this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20251/283

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20251/283/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20251/283/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@ianna
Copy link
Contributor Author

ianna commented Aug 24, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22461/console Started: 2017/08/24 11:18

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #20251 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20251/284

@smuzaffar
Copy link
Contributor

thanks @ianna for applying change to files under tests. code-checks should not have complained about those files. I will check why this happened

@cmsbuild
Copy link
Contributor

+1
Tested at: fbe693b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20251/22461/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
216d761
5420001
84cbb9a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20251/22461/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20251/22461/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Aug 24, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20251/22461/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653934
  • DQMHistoTests: Total failures: 203
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2653542
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dfbe6f7 into cms-sw:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved orp-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ianna @cmsbuild @smuzaffar @kpedro88 @davidlange6