Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to use deterministic event-based seed in SmearedJetProducer (for MT) [92X] #20259

Merged
merged 4 commits into from Sep 15, 2017
Merged

option to use deterministic event-based seed in SmearedJetProducer (for MT) [92X] #20259

merged 4 commits into from Sep 15, 2017

Conversation

kpedro88
Copy link
Contributor

Backport of #20240

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Aug 24, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22467/console Started: 2017/08/24 17:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_2_X.

It involves the following packages:

PhysicsTools/PatUtils

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22470/console Started: 2017/08/24 18:01

@cmsbuild
Copy link
Contributor

+1
Tested at: 7ef5ccb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22470/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4258145
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22470/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22470/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22470/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1795532
  • DQMHistoTests: Total failures: 29473
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1765893
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22498/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1795532
  • DQMHistoTests: Total failures: 29468
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1765898
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Pull request #20259 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22657/console Started: 2017/09/01 19:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

+1
Tested at: b263547
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22657/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4f0ed17
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22657/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22657/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20259/22657/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1903496
  • DQMHistoTests: Total failures: 29816
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1873506
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

slava77
slava77 reviewed Sep 5, 2017
View reviewed changes
PhysicsTools/PatUtils/python/patPFMETCorrections_cff.py
@@ -138,6 +138,7 @@
variation = cms.int32(0), # If not specified, default to 0

seed = cms.uint32(37428479), # If not specified, default to 37428479
useDeterministicSeed = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, default behavior should not be changed in the production release.
Although in this case this is somewhat debateable.
Let's keep it "false"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after some more thought, the requirement for reproducibility of production results wins. So, we should keep it True.

@slava77
Copy link
Contributor

slava77 commented Sep 5, 2017

+1

for #20259 b263547

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 08b3509 into cms-sw:CMSSW_9_2_X Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
analysis-pending backport-ok comparison-available orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpedro88 @cmsbuild @slava77 @davidlange6