DetectorDescription Clang tidy code-checks-all #20273
Conversation
ianna
commented
Aug 25, 2017
ianna
commented
- Deleted members should be public
- Modernize deprecated headers
- Use nullptr [modernize-use-nullptr]
- Access DDRotation members via member functions
- Avoiding the copy if a local copy of the variable is never modified [performance-unnecessary-copy-initialization]
- Making a const reference if the variable is copy-constructed from a const reference but is only used as const reference [performance-unnecessary-copy-initialization]
|
please test |
|
The tests are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/Core @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
-1 Tested at: 04de753 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/DDG4SolidConverter.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/G4CheckOverlap.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/DDGeometryReturnType.cc
>> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/DDDWorld.cc
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/DDG4Builder.cc: In member function 'DDGeometryReturnType DDG4Builder::BuildGeometry()':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/SimG4Core/Geometry/src/DDG4Builder.cc:148:40: error: 'DDRotation DDPosData::rot_' is private within this context
<< gra.edgeData(cit->second)->rot_
^~~~
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/DetectorDescription/Core/interface/DDCompactView.h:14:0,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/DetectorDescription/Core/interface/DDExpandedView.h:13,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-24-2300/src/DetectorDescription/Core/interface/DDSpecifics.h:11,
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
The tests are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
Pull request #20273 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja can you please check and sign again. |
|
+code-checks |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
