Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port SiStripDetSummary from subdetector-DetId classes to TrackerTopology #20274

Merged
merged 7 commits into from
Sep 8, 2017
Merged

Port SiStripDetSummary from subdetector-DetId classes to TrackerTopology #20274

merged 7 commits into from
Sep 8, 2017

Commits on Aug 25, 2017

  1. Port SiStripDetSummary to TrackerTopology (store const pointer at con… 

    …struction time)
    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    04da626 View commit details
    Browse the repository at this point in the history

  2. Pass TrackerTopology to SiStripObjects print methods 

    Changed both printSummary and printDebug, for the classes in
CondFormats/SiStripObjects and CalibFormats/SiStripObjects.
Needed for SiStripDetSummary that is sometimes using a TrackerTopology
(all these classes need to be changed because the methods are called by
DummyCondObjPrinter, which is templated on the object type).
SiStripDetVOff : changed implementation for getLVoffCounts and
getHVoffCounts methods (SiStripDetSummary is not needed there)
    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    9811df3 View commit details
    Browse the repository at this point in the history

  3. Pass TrackerTopology to SistripDetVOff from Builder/Handler

    @pieterdavid
    pieterdavid committed Aug 25, 2017
    8 Configuration menu
    Copy the full SHA
    5845237 View commit details
    Browse the repository at this point in the history

  4. Pass TrackerTopology to print methods: simple cases

    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    8dc098b View commit details
    Browse the repository at this point in the history

  5. DQM/SiStripCommissioningDbClients/src/CommissioningHistosUsingDb.cc: … 

    …move initialization to a configure method (and get TrackerTopology from EventSetup)
    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    a320893 View commit details
    Browse the repository at this point in the history

  6. DQMOffline/CalibTracker/plugins/SiStripPopConBadComponentsDQM.cc: pas… 

    …s TrackerTopology from EventSetup to printSummary
    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    634cf69 View commit details
    Browse the repository at this point in the history

  7. Apply code-checks fixes

    @pieterdavid
    pieterdavid committed Aug 25, 2017
    Configuration menu
    Copy the full SHA
    984449b View commit details
    Browse the repository at this point in the history