Fixed ambigiuous lookup for symbol 'test' #20278
Conversation
We use the namespace 'test' in this header which then breaks every translation unit that also defines a test function, as defining a namespace and a function with the same name doesn't work. This patch gives this namespace a more unique name that we don't run into this problem in the future.
|
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
We use the namespace 'test' in this header which then breaks every
translation unit that also defines a test function, as defining
a namespace and a function with the same name doesn't work.
This patch gives this namespace a more unique name that we don't
run into this problem in the future.