GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

Andrej-CMS · 2017-08-28T10:09:14Z

please see #19048
addressed comment by @davidlange6

cmsbuild · 2017-08-28T10:09:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-08-28T10:09:32Z

A new Pull Request was created by @Andrej-CMS for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-08-28T10:11:25Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20281/339

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20281/339/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20281/339/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

perrotta · 2017-08-28T10:18:37Z

@Andrej-CMS : maybe you can profit and apply also the two small fixes suggested by the code-checker

cmsbuild · 2017-08-28T10:31:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-08-28T10:31:56Z

Pull request #20281 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

perrotta · 2017-08-28T10:33:21Z

please test

cmsbuild · 2017-08-28T10:33:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22517/console Started: 2017/08/28 12:34

cmsbuild · 2017-08-28T10:33:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20281/340

cmsbuild · 2017-08-28T12:20:27Z

+1
Tested at: 7d315d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22517/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5ca2c40
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22517/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22517/git-merge-result

cmsbuild · 2017-08-28T12:20:30Z

Comparison job queued.

cmsbuild · 2017-08-30T13:48:26Z

-1

Tested at: be715ba

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
60ea8c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22588/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22588/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22588/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step4

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step5

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
60ea8c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22588/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22588/git-merge-result

cmsbuild · 2017-08-30T13:48:28Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

slava77 · 2017-08-30T14:07:06Z

@cmsbuild please test
hopefully failures in harvesting are transient
@dmitrijus please take a note.

cmsbuild · 2017-08-30T14:07:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22595/console Started: 2017/08/30 16:07

cmsbuild · 2017-08-30T15:46:31Z

+1
Tested at: be715ba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22595/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
60ea8c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22595/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22595/git-merge-result

cmsbuild · 2017-08-30T15:46:34Z

Comparison job queued.

cmsbuild · 2017-08-30T16:33:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20281/22595/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2653934
DQMHistoTests: Total failures: 210
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2653535
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

slava77 · 2017-08-30T17:47:49Z

+1

for #20281 be715ba

several fixes
- technical fix for the compiler warning in GenJetFlavourInfoPreserver.cc;
- functional fix to select prunedGenParticles as a source of the jet flavor ID, to be in agreement with the pat jets choice
jenkins tests pass and comparisons with baseline show differences only in the recently added slimmedGenJetsFlavourInfos parton flavor distributions

@Andrej-CMS please update the PR title to something more descriptive:
e.g. "GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info"

davidlange6 · 2017-09-01T03:15:29Z

merge

ferencek · 2017-09-04T14:22:43Z

@Andrej-CMS, you are claiming the parton flavor for slimmedJets is based on genParticles but I still see genParticles in https://github.com/Andrej-CMS/cmssw/blob/be715ba8d26c8509e33de8912bff66aa2b3154b9/PhysicsTools/PatAlgos/python/mcMatchLayer0/jetFlavourId_cff.py#L21 overwritten to prunedGenParticles in https://github.com/Andrej-CMS/cmssw/blob/be715ba8d26c8509e33de8912bff66aa2b3154b9/PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py#L351 Am I missing something?

ferencek · 2017-09-04T14:12:29Z

PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

@@ -326,6 +326,7 @@ def miniAOD_customizeMC(process):
    #GenJetFlavourInfos
    process.load("PhysicsTools.JetMCAlgos.HadronAndPartonSelector_cfi")
    task.add(process.selectedHadronsAndPartons)


Apologies for not noticing this earlier but with the updates introduced in this PR, is anything consuming selectedHadronsAndPartons now? If not, this line can be removed.

arizzi · 2017-10-06T10:04:04Z

@Andrej-CMS any answer to the comment from @ferencek

This should be fixed before 940 is out

changed to loop over unsigned int

8e3f660

cmsbuild added this to the CMSSW_9_3_X milestone Aug 28, 2017

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 28, 2017

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 28, 2017

code checks: use override instead of virtual

7d315d0

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 28, 2017

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Aug 28, 2017

cmsbuild removed the tests-started label Aug 28, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 30, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Aug 30, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 30, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 30, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 30, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 30, 2017

Andrej-CMS changed the title ~~GenJetFlavourInfos changes, addressed comments~~ GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info Aug 31, 2017

cmsbuild merged commit 20b60f7 into cms-sw:master Sep 1, 2017

ferencek reviewed Sep 4, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

Andrej-CMS commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

perrotta commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

perrotta commented Aug 28, 2017

cmsbuild commented Aug 28, 2017 •

edited

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

slava77 commented Aug 30, 2017

cmsbuild commented Aug 30, 2017 •

edited

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

slava77 commented Aug 30, 2017

davidlange6 commented Sep 1, 2017

ferencek commented Sep 4, 2017

ferencek Sep 4, 2017

arizzi commented Oct 6, 2017

GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

Conversation

Andrej-CMS commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

perrotta commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

perrotta commented Aug 28, 2017

cmsbuild commented Aug 28, 2017 • edited

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 28, 2017

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

slava77 commented Aug 30, 2017

cmsbuild commented Aug 30, 2017 • edited

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

cmsbuild commented Aug 30, 2017

slava77 commented Aug 30, 2017

davidlange6 commented Sep 1, 2017

ferencek commented Sep 4, 2017

ferencek Sep 4, 2017

Choose a reason for hiding this comment

arizzi commented Oct 6, 2017

cmsbuild commented Aug 28, 2017 •

edited

cmsbuild commented Aug 30, 2017 •

edited