New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix QIE11 capid accessor #20300
fix QIE11 capid accessor #20300
Conversation
please test |
The code-checks are being triggered in jenkins. |
The tests are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: DataFormats/HcalDigi @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
It was noticed recently that the
capid()
accessor in theQIE11DataFrame::Sample
class was not returning the right capids. This was because of an off-by-one error: the indexi_
in theSample
class includes the header word as well as the samples, so the number of header words must be subtracted to get the proper capid for TSi
.attn: @elaird @jmmans @abdoulline