Bugfix for Phase 1 HI Tracking DetachedTripletStep clusters

[abaty]

This PR fixes a bug in the modified Phase 1 HI tracking sequence from PR #18646. The clusters going into the hiDetachedTripletStep were not modified in order to correspond to the new sequence of iterations. Because of this, the clusters were taken from the end of the 1st iteration, essentially bypassing the hit cleaning steps of the previous 3 iterations. This PR adds a Phase 1 modifier so that the clusters are taken from the DetachedQuadStep, run just before the DetachedTripletStep.

Tested using workflow 150. Also quickly tested on central HI events, where timing and memory seemed very similar.

@mandrenguyen

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @abaty for master.

It involves the following packages:

RecoHI/HiTracking

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @echapon, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20303/376

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22585/console Started: 2017/08/30 13:19

[cmsbuild]

+1
Tested at: c42fd40
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20303/22585/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
60ea8c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20303/22585/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20303/22585/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20303/22585/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653934
• DQMHistoTests: Total failures: 210
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2653535
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[perrotta]

+1

• Fix with the correct InputTags the hiDetachedTripletStepClusters in Phase1
• Performance basicaly unchanged, as observed in the description of this PR
• Only a tiny reduction of the number of tracks is observed, as I would expect since now correctly hits cleaning is applied

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1