Add new gen fragments #20331
Add new gen fragments #20331
Conversation
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @jnsandhya (Sandhya Jain) for master. It involves the following packages: Configuration/Generator @efeyazgan, @kkousour, @perrozzi, @kpedro88, @fabozzi, @cmsbuild, @thuer, @GurpreetSinghChahal, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
the filenames contain the word "double" but the process strings say "single", cfr this discussion cms-sw/genproductions#1297 |
|
Hi Luca,
Yes, I can change the file name to single to avoid any confusions.
For the other question, what we want to do is to producing some relvals based on these gen fragments.
And to produce relvals, afaik we should have the fragments as part of CMSSW package.
We just want to avoid them adding locally for every release.
Please let me know how we should proceed for this.
Thanks a lot & Best regards
Sandhya
On Aug 31, 2017, at 3:27 PM, perrozzi <notifications@github.com<mailto:notifications@github.com>> wrote:
the filenames contain the word "double" but the process strings say "single", cfr this discussion cms-sw/genproductions#1297<cms-sw/genproductions#1297>
are the cfg needed both in cmssw and genproductions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20331 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFe0OBf8-xp0wIMhWoHxFWgzn6Kt9DDlks5sdoOmgaJpZM4PIlkk>.
|
|
please change the name, ok to have in cmssw for relvals |
|
The code-checks are being triggered in jenkins. |
|
Pull request #20331 was updated. @efeyazgan, @kkousour, @perrozzi, @kpedro88, @fabozzi, @cmsbuild, @thuer, @GurpreetSinghChahal, @govoni can you please check and sign again. |
|
+code-checks |
|
sorry I have not specificied here (although it was in the genproductions comment) also to use the "p" to indicate a decimal point in the filenames, for better clarity |
|
The code-checks are being triggered in jenkins. |
|
Pull request #20331 was updated. @efeyazgan, @kkousour, @perrozzi, @kpedro88, @fabozzi, @cmsbuild, @thuer, @GurpreetSinghChahal, @govoni can you please check and sign again. |
|
Done now.
On Aug 31, 2017, at 6:38 PM, perrozzi <notifications@github.com<mailto:notifications@github.com>> wrote:
sorry I have not specificied here (although it was in the genproductions comment) also to use the "p" to indicate a decimal point in the filenames, for better clarity
SingleElectronPt15Eta17_27_cfi.py ---> SingleElectronPt15Eta1p7_2p7_cfi.py
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#20331 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFe0OOLGP-h2WQQT2Y8oiZW_WuSBkfK9ks5sdrBrgaJpZM4PIlkk>.
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
+1 |
These gen-fragments are used to make relvlas for HGCal validation