Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug Tracking DQM code which cause wrong rec hits per sub-detector distributions #2034

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jan 15, 2014

fix few bugs in TrackAnalyzer.cc,
which produce wrong ditributions of the rec hits per sub-detector and number of tracker layers

it would be nice to have this fix into the release used for data.vs.mc comparison exercize ... please please please

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_0_X.

fix bug Tracking DQM code which cause wrong rec hits per sub-detector distributions

It involves the following packages:

DQM/TrackingMonitor

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Jan 15, 2014

+1
@ktf this is a bug fix. if it is not too late could you please queue it for pre12? or directly for 700?
thank you,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

Leaving library rule at DQMServices/ClientConfig
>> Building binary DQMQualityTestsExample
>> Building edm plugin tmp/slc5_amd64_gcc481/src/DQMServices/Core/test/DQMServicesCoreROOTExample/libDQMServicesCoreROOTExample.so
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lRecoJetsJetProducers
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc481/external/gcc/4.8.1/bin/../lib/gcc/x86_64-redhat-linux-gnu/4.8.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lSimDataFormatsCaloHit
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc5_amd64_gcc481/src/DQMServices/Examples/src/DQMServicesExamples/libDQMServicesExamples.so] Error 1
gmake: **\* Waiting for unfinished jobs....
Leaving library rule at src/DQMServices/Components/test
Copying tmp/slc5_amd64_gcc481/src/DQMServices/Core/test/DQMFastMatchTest/DQMFastMatchTest to productstore area:
Leaving library rule at src/DQMServices/Core/test


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2034/2101/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (but tests are reportedly failing). @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Jan 23, 2014
…s_independentBUGfix

DQM fixes -- Fix bug in Tracking DQM code which cause wrong rechits distributions per sub-detector.
@ktf ktf merged commit 76adb47 into cms-sw:CMSSW_7_0_X Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants