Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run2-hcx148 Correct the access of Geometry information for Hcal #20349

Merged
merged 4 commits into from Sep 11, 2017
Merged

Run2-hcx148 Correct the access of Geometry information for Hcal #20349

merged 4 commits into from Sep 11, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 1, 2017

Also tried to cleanup a bit

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 1, 2017

@cmsbuild Please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Sep 1, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22658/console Started: 2017/09/01 20:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

JetMETCorrections/MinBias

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20349/454

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

+1
Tested at: 5d973c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22658/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
91fd772
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22658/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22658/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22658/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656222
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2655831
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

+1
Tested at: 4ee6363
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22666/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a9c9ffa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22666/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22666/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

Pull request #20349 was updated. @cmsbuild, @monttj can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 2, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22669/console Started: 2017/09/02 17:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20349/467

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

+1
Tested at: 06cb1b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22669/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a9c9ffa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22669/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22669/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20349/22669/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656222
  • DQMHistoTests: Total failures: 196
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2655837
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_9_3_X Sep 6, 2017
@bsunanda
Copy link
Contributor Author

bsunanda commented Sep 8, 2017

@monttj @davidlange6 Please review & approve

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 69441fc into cms-sw:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bsunanda @cmsbuild @davidlange6 @smuzaffar