Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerBxMonitor: add support for 2D plots #20373

Merged
merged 1 commit into from Sep 12, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 4, 2017

  • add support for plots vs BX and vs lumisetion;
    these plots are disabled by default.

  • make the 1D plots vs BX optional;
    these plots are enabled by default.

  - add support for plots vs BX and vs lumisetion;
    these plots are disabled by default.

  - make the 1D plots vs BX optional;
    these plots are enabled by default.
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 4, 2017

@cmsbuild, please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 4, 2017

backport #20372

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22701/console Started: 2017/09/04 18:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_2_X.

It involves the following packages:

DQM/HLTEvF

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @Martin-Grunewald, @silviodonato, @fwyzard, @vanbesien can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20373/22701/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1903462
  • DQMHistoTests: Total failures: 44692
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1858596
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3ff96f6 into cms-sw:CMSSW_9_2_X Sep 12, 2017
@fwyzard fwyzard deleted the TriggerBxMonitor_2d_plots_81x branch January 31, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants