Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixelPhase1 trends by lumiblock for offline #20386

Merged

Conversation

folguera
Copy link
Contributor

@folguera folguera commented Sep 5, 2017

We've added a switch to produce trends plots by Lumiblock (10LS) for OfflineDQM, while keeping the LS granularity for online.

This supersedes #20205, which can be closed.

This approach, suggested by @fioriNTU, should be simpler than the originally proposed in #20205.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

A new Pull Request was created by @folguera (Santiago Folgueras) for master.

It involves the following packages:

DQM/Integration
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Config

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@batinkov, @hdelanno, @makortel, @fioriNTU, @thomreis, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20386/508

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22969/console Started: 2017/09/14 12:17

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20386/22969/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646515
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646124
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 09e02e8 into cms-sw:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants