Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified vbf filter #20392

Merged
merged 9 commits into from Sep 19, 2017
Merged

Modified vbf filter #20392

merged 9 commits into from Sep 19, 2017

Conversation

gmandorl
Copy link

@gmandorl gmandorl commented Sep 6, 2017

VBFGenJetFilter.cc has been extended.
Possible requirements on the invariant mass of the two pt-leading genJets.
The considered genJets can also be asked to have a minimum DeltaR from the event charged prompt leptons.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @gmandorl for CMSSW_7_1_X.

It involves the following packages:

AnalyzerMiniAOD/GenJetAnalyzer
GeneratorInterface/GenFilters

The following packages do not have a category, yet:

AnalyzerMiniAOD/GenJetAnalyzer
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@gmandorl
Copy link
Author

gmandorl commented Sep 6, 2017

I make a mistake. The package
AnalyzerMiniAOD/GenJetAnalyzer
wasn't ment to be updated in cmssw.

Do I create a new PR with just
GeneratorInterface/GenFilters
?

@perrozzi
Copy link
Contributor

perrozzi commented Sep 6, 2017

you can use
git rm --cached -r AnalyzerMiniAOD/GenJetAnalyzer
and commit to remove it from git but keep it local

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Pull request #20392 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@gmandorl
Copy link
Author

gmandorl commented Sep 6, 2017

I removed the package AnalyzerMiniAOD/GenJetAnalyzer

@perrozzi
Copy link
Contributor

perrozzi commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22741/console Started: 2017/09/06 11:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20392/22741/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 3706
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 837992
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #20392 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22902/console Started: 2017/09/12 17:05

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20392/22902/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 4158
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 837540
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bd6cf02 into cms-sw:CMSSW_7_1_X Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants