Update for DTCalibration offline workflows #20405
Conversation
This commit includes changes which were done by several past contributors, but never reached the official repo.
This commit contains a rewrite of the DTcalibration workflow.
Main changes:
* All workflows inherit from one common DTCalibration object
* The CLI is dynamically build and each operations follows the structure
dtCalibration [workflow] [workflow_mode] [command] using python
subparsers
* Each worklflow is implemented in a single class.
* Each command needs to implement a function
* prepare_[workflow_mode]_[command]
which prepares pset files for this command.
* Commonly used commands like submit, check, run are implemented in
the parent class and may be ovewritten in the child classes if needed.
* Add new crab tools for crab3 integration
* automated proxy creation
* Delete obsolete files in workflows
Documentation about the updated workflow can be found in:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DTCalibrationTools
Imports of CondCore.DBCommon.ConDBSetup_cfi are deprecated and now replaced by CondCore.CondDB.CondDB_cfi. The new object does not need the auhentication mehtod parameter anymore and the connect parameter is already set and is now set outside of the database objects.
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @tobias-pook (Tobias) for master. It involves the following packages: CalibMuon/DTCalibration @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20405/529 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20405/529/git-diff.patch You can run |
|
@tobias-pook please implement the code-checker suggestions |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Any updates about the pull request ? |
|
Hi, could we go ahead with this PR? We believe we've addressed all the comments |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
Hi, we seem to be stuck with this PR again.. |
|
@davidlange6 Could we merge this PR? |
|
Hi @davidlange6 sorry to insist, but what is holding this PR? |
|
10k lines of changes?
… On Dec 4, 2017, at 5:41 PM, Luca Pernie ***@***.***> wrote:
Hi @davidlange6 sorry to insist, but what is holding this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I asked because DT people are waiting for it, and asked me for a time estimation. |
|
+1 |
Running versions of the DT offline calibration was only available in private forks for some years now. This PR adds a working version again.
The changes include:
New python workflow system using crab3
Fixes to t0 determination
Cleanup and tweaks for segment selection.