Tau rereco for MiniAOD of 80X legacy samples #20412
Conversation
Tau rereco for MiniAOD of 80X legacy samples
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @mbluj for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
| process.load("RecoTauTag.Configuration.RecoPFTauTag_cff") | ||
| from PhysicsTools.PatAlgos.tools.helpers import listModules | ||
| for module in listModules(process.PFTau): | ||
| _makePatTausTaskWithTauReReco.add(module) |
There was a problem hiding this comment.
please define tasks and derive relevant sequences from them in RecoPFTauTag_cff so that here you can import the task and simply attach it instead of constructing it in place.
We should eventually migrate to that.
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| makePatTausTask = cms.Task( | |||
| # reco pre-production | |||
| patHPSPFTauDiscriminationTask, | |||
| #patHPSPFTauDiscriminationTask, | |||
There was a problem hiding this comment.
is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant
Same for the older patTauJetCorrections below
|
Comparison is ready Comparison Summary:
|
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
@slava77, Is the PR technically OK? |
|
On 9/18/17 12:45 AM, mbluj wrote:
@slava77 <https://github.com/slava77>, Is the PR technically OK?
I still need to run this to see that everything is as expected.
If so, is a decision of Tau POG conveners ***@***.***
<https://github.com/steggema>, @isobelojalvo
<https://github.com/isobelojalvo>) the last missing item to merge or
close the PR?
I will need a confirmation to proceed with integration.
BTW, even if the decision is negative, i.e. 80X legacy MiniAOD will be
performed with 2016 setup of tau-reco&id I vote to keep migration from
classic sequences to tasks performed in this PR.
I agree
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20412 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbmccKixRwIwl_OPZx6ZZ2lwTf2xkks5sjh-OgaJpZM4PPlhE>.
|
|
On Mon, Sep 18, 2017 at 2:31 PM, Slava Krutelyov <notifications@github.com>
wrote:
On 9/18/17 12:45 AM, mbluj wrote:
> @slava77 <https://github.com/slava77>, Is the PR technically OK?
I still need to run this to see that everything is as expected.
OK, thanks
> If so, is a decision of Tau POG conveners ***@***.***
> <https://github.com/steggema>, @isobelojalvo
> <https://github.com/isobelojalvo>) the last missing item to merge or
> close the PR?
I will need a confirmation to proceed with integration.
> BTW, even if the decision is negative, i.e. 80X legacy MiniAOD will be
> performed with 2016 setup of tau-reco&id I vote to keep migration from
> classic sequences to tasks performed in this PR.
I agree
OK, I will contact directly the conveners when you are done with the
checks. Then, accordingly to their decision the PR will be merged or I
remove the customization for 80X legacy processing leaving
Sequences-to-Tasks migration (and adjust title of the PR accordingly).
Michał
|
|
On 9/18/17 5:39 AM, mbluj wrote:
OK, I will contact directly the conveners when you are done with the
checks. Then, accordingly to their decision the PR will be merged or I
remove the customization for 80X legacy processing leaving
Sequences-to-Tasks migration (and adjust title of the PR accordingly).
until there is a confirmation that this is a needed PR in full, checks
from my side will be on rather low priority.
|
|
I confirm for the tau POG that we want this integrated, so please proceed with the checks and the integration. Thanks! |
|
@cmsbuild please test to refresh the tests that were deleted already |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
From 1325.5 (ttbar from 2016 AOD tranche IV) running on 1K events:
This looks as expected. |
|
+1
|
|
merge |
This pull requests adds tau re-reconstruction to MiniAOD step for legacy re-reco of 2016 data and MC produced with CMSSW_80X. The re-reconstruction is added to MiniAOD setup (
PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py) when therun2_miniAOD_80XLegacyEra is requested.Expected effect of the PR was discussed in the xPOG meeting on 5 September 2017 [1].
Note 1: During the xPOG meeting it was agreed that the PR (when sent to official CMSSW repository) will be scrutinized, but its integration will be hold until Tau POG conveners (@steggema, @isobelojalvo) give their final green light. The procedure is to speedup the integration process.
Note 2: The PR consists of purely technical modification of
PhysicsTools/PatAlgos/python/producersLayer1/tauProducer_cff.pyfile: it is a cleaning which avoids re-reco of cut-based tau discriminants which is not necessary. In addition, input files for tau reco tests are updated inRecoTauTag/Configuration/test/ZTT-validation.txtfile.[1] https://indico.cern.ch/event/663315/contributions/2708403/attachments/1518558/2371260/mbluj_TauId_80XLegacyMiniAOD_5Sep2017.pdf