Fix crashes in edmConfigBrowser #20419
Conversation
The edmConfigBrowser modifies member functions of standard configuration python objects. The modification to the cms.Process __init__ was not general enough to deal with the change of number of allowed arguments. In addition, the 'replace' modification could not deal with something being replaced with None.
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/GuiBrowsers @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+code-checks |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
hold |
|
Pull request has been put on hold by @Dr15Jones |
|
The code-checks are being triggered in jenkins. |
|
Pull request #20419 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
please test |
|
+1 |
|
unhold |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
hold
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+code-checks |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
The edmConfigBrowser modifies member functions of standard configuration
python objects. The modification to the cms.Process init was
not general enough to deal with the change of number of allowed
arguments. In addition, the 'replace' modification could not deal
with something being replaced with None.