Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[94X] Replace GBL in CMSSW code with GBL code from external library. #20430

Merged
merged 1 commit into from Sep 10, 2017

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Sep 8, 2017

No functional change.
Just avoiding to manually integrate development and fixes of the non-CMS-specific tool GBL.
For historic reasons it was "integrated" by simply copying the code over to CMSSW.

This PR is a clean-up of this code duplication.

Supersedes #20262, but not its backports (the external is only added to 94X).

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The code-checks are being triggered in jenkins.

@ghellwig
Copy link
Author

ghellwig commented Sep 8, 2017

please test with cms-sw/cmsdist#3384

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

A new Pull Request was created by @ghellwig (Gregor Mittag) for master.

It involves the following packages:

Alignment/ReferenceTrajectories

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3384
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22805/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20430/578

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20430/22805/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 209
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642042
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@ghellwig
Copy link
Author

ghellwig commented Sep 8, 2017

please test with cms-sw/cmsdist#3384

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3384
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22816/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20430/22816/summary.html

There are some workflows for which there are errors in the baseline:
1306.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2517698
  • DQMHistoTests: Total failures: 206
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2517307
  • DQMHistoTests: Total skipped: 185
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6cfac74 into cms-sw:master Sep 10, 2017
@ghellwig ghellwig deleted the get-GBL-from-externals_94X branch September 11, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants