New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[94X] Replace GBL in CMSSW code with GBL code from external library. #20430
[94X] Replace GBL in CMSSW code with GBL code from external library. #20430
Conversation
The code-checks are being triggered in jenkins. |
please test with cms-sw/cmsdist#3384 |
A new Pull Request was created by @ghellwig (Gregor Mittag) for master. It involves the following packages: Alignment/ReferenceTrajectories @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The tests are being triggered in jenkins. |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test with cms-sw/cmsdist#3384 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
No functional change.
Just avoiding to manually integrate development and fixes of the non-CMS-specific tool GBL.
For historic reasons it was "integrated" by simply copying the code over to CMSSW.
This PR is a clean-up of this code duplication.
Supersedes #20262, but not its backports (the external is only added to 94X).