Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatCandidates Lepton.h : make the miniPFIsolation() const #20431

Merged
merged 1 commit into from Sep 14, 2017

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Sep 8, 2017

backport bugfix part of #20367 to 92X as requested in #20414

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_9_2_X.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22810/console Started: 2017/09/08 13:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Sep 8, 2017

+1

for #20431 87e4de4

  • technical
  • jenkins tests pass

This is an important fix of (const) access to the miniPFIsolation. @davidlange6 please merge soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20431/22810/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904608
  • DQMHistoTests: Total failures: 44113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1860321
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants