muon hit

[swagata87]

Currently, the variable nMatchedStations is set to zero. And number of valid muon hits is accessed in a way that it always returns zero. As these 2 variables will be essential for the analysis that we plan to do using the dimuon scouting data, so I changed the code in a way that these variables returns meaningful value and save that in the event. (Same as PR#20434)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20441/593

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20441/593/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20441/593/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20441 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20441/599

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22853/console Started: 2017/09/11 15:49

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 0ea8c0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20441/22853/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dfc38ed
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20441/22853/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20441/22853/git-merge-result

[cmsbuild]

Comparison job queued.

[davidlange6]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20441/22853/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2563849
• DQMHistoTests: Total failures: 200
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2563463
• DQMHistoTests: Total skipped: 186
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files