reject seed candidates not part of superclusters [93X]

[kpedro88]

Backport of #20458

[kpedro88]

assign upgrade

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X.

It involves the following packages:

RecoEcal/EgammaClusterAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from reject seed candidates not part of superclusters #20458

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22877/console Started: 2017/09/11 23:54

[cmsbuild]

+1
Tested at: 0664da8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22877/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3043808
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22877/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22877/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22877/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2641982
• DQMHistoTests: Total failures: 213
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2641580
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[kpedro88]

+1

[cmsbuild]

Pull request #20459 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22918/console Started: 2017/09/13 03:41

[cmsbuild]

+1
Tested at: 57e3745
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22918/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9fb6347
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22918/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22918/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20459/22918/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2641982
• DQMHistoTests: Total failures: 201
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2641592
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[slava77]

+1

for #20459 57e3745

• same as the master version reject seed candidates not part of superclusters #20458 57e3745; relevant only for cases where processing would crash [currently happens frequently enough in HGCAL reco ]
• jenkins tests pass

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1