Miscellaneous updates to CaloLayer1 DQM services #20465

nsmith- · 2017-09-11T16:52:36Z

Forward-port of #20464

cmsbuild · 2017-09-11T16:52:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-11T16:54:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20465/634

cmsbuild · 2017-09-11T16:54:53Z

A new Pull Request was created by @nsmith- (Nicholas Smith) for master.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@makortel, @threus, @kreczko, @thomreis, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-09-12T11:33:46Z

+1

cmsbuild · 2017-09-12T11:34:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22897/console Started: 2017/09/12 14:22

cmsbuild · 2017-09-12T11:34:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2017-09-12T14:59:58Z

+1
Tested at: 9de1dbc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20465/22897/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
69441fc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20465/22897/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20465/22897/git-merge-result

cmsbuild · 2017-09-12T15:00:00Z

Comparison job queued.

nsmith- · 2017-09-12T16:54:40Z

DQM/L1TMonitor/python/L1TStage2CaloLayer1_cfi.py

@@ -7,4 +7,6 @@
    hcalTPSourceSent = cms.InputTag("hcalDigis"),
    fedRawDataLabel  = cms.InputTag("rawDataCollector"),
    histFolder = cms.string('L1T/L1TStage2CaloLayer1'),
+    # HF minBias bit is not yet unpacked on HCAL side, so we don't compare them


FYI @christopheralanwest here is where you can enable comparing the HF feature bit 2 when it is available from the HCAL unpacker

The HF feature bit 2 is currently not available because of a uHTR FW bug, not a problem in the unpacker. Updated FW that includes a fix for this problem became available just yesterday, and is currently being tested. If the updated FW works as intended, this flag will become obsolete.

Great news!
This is all ready to be merged so lets just put that in a new PR.

fabiocos · 2018-01-18T08:14:11Z

-1
pending clarification requested

thomreis · 2018-01-22T08:54:48Z

@fabiocos can this be considered for merging now since @nsmith- commented that the unpacker cannot replace the code in this module?

thomreis · 2018-01-29T09:09:27Z

@fabiocos @davidlange6 can this PR finally be merged?
It was created more than four months ago and always needs to be added manually to the online DQM until it is in a release.

fabiocos · 2018-01-29T09:24:24Z

please test

cmsbuild · 2018-01-29T09:24:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25720/console Started: 2018/01/29 10:25

cmsbuild · 2018-01-29T11:52:03Z

+1
Tested at: 9de1dbc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20465/25720/summary.html

cmsbuild · 2018-01-29T11:52:06Z

Comparison job queued.

cmsbuild · 2018-01-29T13:08:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20465/25720/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-20465/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2464330
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2464160
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 986.21 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

thomreis · 2018-01-30T09:32:19Z

Passed the test again.
@fabiocos @davidlange6 can it be merged now?

fabiocos · 2018-01-30T15:23:38Z

+1

thomreis · 2018-01-30T15:27:39Z

Thanks.

nsmith- added 2 commits September 11, 2017 18:45

Miscellaneous updates to CaloLayer1 DQM services

4a01574

code-check

9de1dbc

cmsbuild added this to the CMSSW_9_4_X milestone Sep 11, 2017

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 11, 2017

This was referenced Sep 11, 2017

Miscellaneous updates to L1T CaloLayer1 subsystem DQM dmwm/deployment#538

Merged

Miscellaneous updates to CaloLayer1 DQM services #20464

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 12, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 12, 2017

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2017

nsmith- commented Sep 12, 2017

View reviewed changes

cmsbuild added orp-rejected and removed orp-pending labels Jan 18, 2018

smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jan 29, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 29, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 29, 2018

cmsbuild added orp-approved and removed orp-rejected labels Jan 30, 2018

cmsbuild merged commit 275f564 into cms-sw:master Jan 30, 2018

nsmith- mentioned this pull request Feb 26, 2018

Enable comparison of HF minBias feature bit readout in CaloLayer1 #22349

Merged

nsmith- deleted the calol1_dqmUpd_93x branch April 10, 2018 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miscellaneous updates to CaloLayer1 DQM services #20465

Miscellaneous updates to CaloLayer1 DQM services #20465

nsmith- commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

dmitrijus commented Sep 12, 2017

cmsbuild commented Sep 12, 2017 •

edited

cmsbuild commented Sep 12, 2017

cmsbuild commented Sep 12, 2017

cmsbuild commented Sep 12, 2017

nsmith- Sep 12, 2017

christopheralanwest Sep 15, 2017

nsmith- Sep 15, 2017

fabiocos commented Jan 18, 2018

thomreis commented Jan 22, 2018

thomreis commented Jan 29, 2018

fabiocos commented Jan 29, 2018

cmsbuild commented Jan 29, 2018 •

edited

cmsbuild commented Jan 29, 2018

cmsbuild commented Jan 29, 2018

cmsbuild commented Jan 29, 2018

thomreis commented Jan 30, 2018

fabiocos commented Jan 30, 2018

thomreis commented Jan 30, 2018

Miscellaneous updates to CaloLayer1 DQM services #20465

Miscellaneous updates to CaloLayer1 DQM services #20465

Conversation

nsmith- commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

cmsbuild commented Sep 11, 2017

dmitrijus commented Sep 12, 2017

cmsbuild commented Sep 12, 2017 • edited

cmsbuild commented Sep 12, 2017

cmsbuild commented Sep 12, 2017

cmsbuild commented Sep 12, 2017

nsmith- Sep 12, 2017

Choose a reason for hiding this comment

christopheralanwest Sep 15, 2017

Choose a reason for hiding this comment

nsmith- Sep 15, 2017

Choose a reason for hiding this comment

fabiocos commented Jan 18, 2018

thomreis commented Jan 22, 2018

thomreis commented Jan 29, 2018

fabiocos commented Jan 29, 2018

cmsbuild commented Jan 29, 2018 • edited

cmsbuild commented Jan 29, 2018

cmsbuild commented Jan 29, 2018

cmsbuild commented Jan 29, 2018

thomreis commented Jan 30, 2018

fabiocos commented Jan 30, 2018

thomreis commented Jan 30, 2018

cmsbuild commented Sep 12, 2017 •

edited

cmsbuild commented Jan 29, 2018 •

edited