Fix static analyzer warnings in 'Alignment/CocoaModel/src/OpticalObject.cc' #20512
Conversation
…ct.cc'.
${CMSSW_BASE}/src/Alignment/CocoaModel/src/OpticalObject.cc:291:31: warning: Function call argument is an uninitialized value
if(ALIUtils::debug >= 5 ) std::cout << " OpticalObject::transformCylindrical2Cartesian " << ii << " " << newcoor[ii] << std::endl;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
${CMSSW_BASE}/src/Alignment/CocoaModel/src/OpticalObject.cc:292:5: warning: Function call argument is an uninitialized value
theCoordinateEntryVector[ii]->setValue( newcoor[ii] );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ghellwig (Gregor Mittag) for master. It involves the following packages: Alignment/CocoaModel @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Fixes this remaining warning in this package.
${CMSSW_BASE}/src/Alignment/CocoaModel/src/OpticalObject.cc:291:31: warning: Function call argument is an uninitialized value
if(ALIUtils::debug >= 5 ) std::cout << " OpticalObject::transformCylindrical2Cartesian " << ii << " " << newcoor[ii] << std::endl;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
${CMSSW_BASE}/src/Alignment/CocoaModel/src/OpticalObject.cc:292:5: warning: Function call argument is an uninitialized value
theCoordinateEntryVector[ii]->setValue( newcoor[ii] );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.