Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 20494 plus l1stage1 alias #20518

Merged
merged 5 commits into from Sep 18, 2017
Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Sep 14, 2017

This PR 20494 plus changes in configuration aliases needed for l1 stage1.

It introduces a new alias run2_mc_l1stage1 and adjusts the configuration of HLT that is used by the AddOn tests, to pick up this new alias.

PR 20494: 'run2_mc'was updated to '93X_mcRun2_asymptotic_v2', which is what we want for Stage2.

For Stage1, we keep '93X_mcRun2_asymptotic**_v1**' as it have conditions relevant for 2015.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@rekovic
Copy link
Contributor Author

rekovic commented Sep 14, 2017

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20518/703

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22981/console Started: 2017/09/14 18:39

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

Configuration/AlCa
Configuration/HLT

@ghellwig, @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: c30cba8

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3533e9c
3f63597
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Thu Sep 14 21:09:12 2017-date Thu Sep 14 21:00:40 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3533e9c
3f63597
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22981/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 209
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646471
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Sep 15, 2017

Looks like the fastsim1 addOnTest needs to change auto:run2_mc to auto:run2_mc_l1stage1 as well (in file Utilities/ReleaseScripts/scripts/addOnTests.py).

@davidlange6
Copy link
Contributor

davidlange6 commented Sep 15, 2017 via email

@arunhep
Copy link
Contributor

arunhep commented Sep 15, 2017

@davidlange6

maybe its time to re-discuss how to manage GTs across years as the detector is slowly upgraded and improved? (as it seems the agreed solution years ago has been abandoned before commissioned)

I am not aware of any strategy which was discussed in past. And yes we are ready to discuss again.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor Author

rekovic commented Sep 15, 2017

+1 (even if l1 not required)

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20518/22999/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 197
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646483
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 17, 2017

+1

@rekovic
Copy link
Contributor Author

rekovic commented Sep 18, 2017

@davidlange6, @Dr15Jones, @smuzaffar, can you please sign or comment.
Thanks.

@smuzaffar
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@arunhep
Copy link
Contributor

arunhep commented Sep 18, 2017

@davidlange6 we have few other updates lined up so please merge this PR at your earliest convenience.
Thanks.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e133687 into cms-sw:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants