Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new paths to the monitoring #20536

Merged
merged 4 commits into from Sep 29, 2017
Merged

Adding new paths to the monitoring #20536

merged 4 commits into from Sep 29, 2017

Conversation

sscruz
Copy link
Contributor

@sscruz sscruz commented Sep 15, 2017

Monitoring for Muon POG paths.

  • Output of the modules: /afs/cern.ch/work/s/sesanche/public/DQM/sep14/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

  • This PR will add 178540 bins

@cmsbuild cmsbuild changed the base branch from CMSSW_9_4_X to master September 15, 2017 10:51
@cmsbuild
Copy link
Contributor

@sscruz, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20536/725

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20536/725/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20536/725/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

@heppye
Copy link
Contributor

heppye commented Sep 15, 2017

@dmitrijus,@mia PR is to support higgs trigger proposal targeting for v4. May DQM and STEAM please provide a quick look. Please push the integration if possible. Thanks, Ye (for HIGGS)

@mtosi
Copy link
Contributor

mtosi commented Sep 15, 2017

@sscruz please follow the suggestions by @cmsbuild

@dmitrijus
Copy link
Contributor

@sscruz Please apply the code checks.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20536/811

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sscruz for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor

mtosi commented Sep 19, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23081/console Started: 2017/09/19 17:14

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20536/968

@cmsbuild
Copy link
Contributor

Pull request #20536 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Sep 27, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23247/console Started: 2017/09/27 14:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20536/23247/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2698383
  • DQMHistoTests: Total failures: 279
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697915
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 15 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e9f1976 into cms-sw:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants