Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondDB KeyList adapted to avoid dependency on the target CondFormat. #2055

Merged
merged 1 commit into from Jan 20, 2014

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Jan 17, 2014

Changes involve KeyList interface. Packages affected:

CondCore/CondDB

Depending packages fixed for this change:

CondCore/DTPlugins
CondTools/DT

Workflows affected passed the matrix tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_0_X.

CondDB KeyList adapted to avoid dependency on the target CondFormat.

It involves the following packages:

CondCore/CondDB
CondCore/DTPlugins
CondTools/DT

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Jan 17, 2014

Why 70X?

@ggovi
Copy link
Contributor Author

ggovi commented Jan 17, 2014

In principle this is completing the fixes i sent yesterday... Too late for 70X?

On Jan 17, 2014, at 11:05 AM, Giulio Eulisse wrote:

Why 70X?


Reply to this email directly or view it on GitHub.

@apfeiffer1
Copy link
Contributor

+1

On Fri, Jan 17, 2014 at 11:08 AM, ggovi notifications@github.com wrote:

In principle this is completing the fixes i sent yesterday... Too late
for 70X?

On Jan 17, 2014, at 11:05 AM, Giulio Eulisse wrote:

Why 70X?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2055#issuecomment-32593396
.

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jan 20, 2014
DB fixes -- CondDB KeyList adapted to avoid dependency on the target CondFormat.
@ktf ktf merged commit 0465fec into cms-sw:CMSSW_7_0_X Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants