Support hitless seeds in GroupedCkfTrajectory [92X]

[folguera]

Enable hitless seed compatibility to the GroupedCkfTrajectory so it can be used in the muon HLT reconstruction. Change is transparent to any user of the GroupedCkfTrajectory.

Removed unused function in BaseCkfTrajectoryBuilder. This is a back port of #20556

[cmsbuild]

A new Pull Request was created by @folguera (Santiago Folgueras) for CMSSW_9_2_X.

It involves the following packages:

RecoTracker/CkfPattern

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23033/console Started: 2017/09/18 13:00

[cmsbuild]

+1
Tested at: 1d8c905
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20557/23033/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
46c23e1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20557/23033/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20557/23033/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20557/23033/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1904626
• DQMHistoTests: Total failures: 44280
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1860172
• DQMHistoTests: Total skipped: 174
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[perrotta]

+1

• Identical to Support hitless seeds in GroupedCkfTrajectory #20556, already merged in the master release
• Backport requested for use in HLT development.
• Same comments as for the version in the master apply, i.e.:
  • It makes GroupedCkfTrajectory compatible to hit-less seeds, as it is already in CkfTrajectoryBuilder
  • No visible regression on jenkins test results
  • Not obvious whether it can affect also current use cases, but if so it is only with a negligible rate (it should have issued warning messages that were never noticed so far), and in any case it is endorsed by tracking POG, see Support hitless seeds in GroupedCkfTrajectory #20556 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge