New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[94X] Fix thread safety warnings in 'Alignment/MillePedeAlignmentAlgorithm'. #20559
[94X] Fix thread safety warnings in 'Alignment/MillePedeAlignmentAlgorithm'. #20559
Conversation
…pendentPedeLabeler'. This line was actually never executed: The if statement always returned true because the reverse map is already built in the constructor.
…pendentPedeLabeler'. This line was actually never executed: The if statement always returned true because the reverse map is already built in the constructor.
please test |
The code-checks are being triggered in jenkins. |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ghellwig (Gregor Mittag) for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 818b48c The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Mon Sep 18 17:09:41 2017-date Mon Sep 18 17:01:10 2017 s - exit: 23552 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
hold |
please test |
The code-checks are being triggered in jenkins. |
+code-checks |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Should fix all thread-safety warnings issued by the static analyzer in this package.