New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle failed file opening in DQMRootSource #20560
Properly handle failed file opening in DQMRootSource #20560
Conversation
Since ROOT 6 is unable to propagate exceptions through cling, it is necessary to trap file open errors in TFileAdaptor and then call edm::threadLocalException::getException() to get the underlying exception to be rethrown.
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20560/767 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20560/767/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQMServices/FwkIO @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
This code replicates the steps done in InputFile.cc |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Since ROOT 6 is unable to propagate exceptions through cling,
it is necessary to trap file open errors in TFileAdaptor and
then call edm::threadLocalException::getException() to get
the underlying exception to be rethrown.