New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ClassDefOverride instead of ClassDef to avoid inconsistent-missing-override warning #20570
use ClassDefOverride instead of ClassDef to avoid inconsistent-missing-override warning #20570
Conversation
…g-override warning
The code-checks are being triggered in jenkins. |
+code-checks |
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: SimDataFormats/CaloHit @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
Thanks for fixing it. |
merge |
@ianna, #20534 caused inconsistent-missing-override warnings
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_4_X_2017-09-18-1700/SimDataFormats/CaloHit
This PR should fix these