Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dqm for DoubleMu3_DCA_PFMET50_PFMHT60 #20584

Merged
merged 2 commits into from Oct 10, 2017

Conversation

gkaratha
Copy link
Contributor

Dear experts,

No new code developed. Only reuse what was already there for a modified path. Thanks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20584/821

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkaratha for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

please read https://www.python.org/dev/peps/pep-0008/ in your spare time.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23085/console Started: 2017/09/19 18:09

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@mtosi
Copy link
Contributor

mtosi commented Sep 19, 2017

can you please quantify the increase in #bins ?

@gkaratha
Copy link
Contributor Author

Dear @mtosi ,

I did not increase the bins. They are the same as in DoubleMu3_DZ_PFMET50_PFMHT60. Or I did not understand the question? Thanks

@mtosi
Copy link
Contributor

mtosi commented Sep 19, 2017 via email

@gkaratha
Copy link
Contributor Author

Yes for a new path

@mtosi
Copy link
Contributor

mtosi commented Sep 19, 2017 via email

@gkaratha
Copy link
Contributor Author

ok sure! if i am not mistaken 354 in total, for all different plots (meaning i dont count numerator/denominator) . But is less than in the doublemu3_dz_pfmet50_pfmht60. I created less plots now. Thanks

@gkaratha
Copy link
Contributor Author

also i can remove some plots that i think are redundant (like 2d for muon pt)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20584/848

@cmsbuild
Copy link
Contributor

Pull request #20584 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Sep 20, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23119/console Started: 2017/09/20 17:54

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20584/23119/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2649968
  • DQMHistoTests: Total failures: 204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2649575
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@mtosi
Copy link
Contributor

mtosi commented Oct 3, 2017

@dmitrijus @davidlange6
can we proceed w/ the integration of this PR ?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 978155a into cms-sw:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants