Add put interface using EDPutToken #20595
Conversation
produce can not directly return an EDPutToken since we need to be able to call 'setBranchAlias' on the returned value. Using a SetBranchAlias class that can be converted to a EDPutToken solves the problem.
Event, LuminosityBlock and Run now accept a EDPutToken as an argument to 'put'. This is the first step to a speedup of the put system.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20595/835 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20595/835/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
@davidlange6 I do not see any reasonable way this change could cause a difference for reco. Non of the code added changes how any of our present code works. It could shift things in memory a bit, but we hope our results are not dependent upon exact memory addresses used (although anyone sorting by pointer addresses might see a difference). |
|
@davidlange6 @slava77 do either of you know how to determine what the comparison system thought was different? |
|
Follow the links for "Comparison is ready" -> "See Comparison Results" -> "validateJR" -> "logRootQA.log" JR results differ 9 all_OldVSNew_TTbar14TeV2023D17wf20034p0 HOWEVER, before worrying much about this, go to the summary of the test made |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
As a preliminary to improving the performance of the 'put' system, we introduce the use of the EDPutToken.