Adding back thepeginterface -92x #20597
Conversation
|
A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for CMSSW_9_2_X. It involves the following packages: GeneratorInterface/ThePEGInterface @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 5e72235 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h: In instantiation of 'ThePEG::Pointer::RCPtr& ThePEG::Pointer::RCPtr::create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]':
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:126:22: required from 'static ThePEG::Pointer::RCPtr ThePEG::Pointer::RCPtr::Create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:869:69: required from 'static ThePEG::Pointer::PtrTraits >::pointer ThePEG::Pointer::PtrTraits >::create(ThePEG::Pointer::PtrTraits >::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::PtrTraits >::pointer = ThePEG::Pointer::RCPtr; ThePEG::Pointer::PtrTraits >::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/PtrTraits.h:204:55: required from 'typename ThePEG::Pointer::Ptr::pointer ThePEG::Pointer::new_ptr(const T&) [with T = ThePEG::LesHouchesInterface; typename ThePEG::Pointer::Ptr::pointer = ThePEG::Pointer::RCPtr]'
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:38:53: required from here
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:147:9: error: invalid new-expression of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:30:7: note: because the following virtual functions are pure within 'ThePEG::LesHouchesInterface':
class LesHouchesInterface : public LesHouchesReader {
^
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGHadronizer.cc
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:10:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Interface/ClassDocumentation.h:13:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Config/ThePEG.h:23:
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:147:15: error: allocating an object of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:126:14: note: in instantiation of member function 'ThePEG::Pointer::RCPtr::create' requested here
return p.create(t);
^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
the errors are expected, it needs thepeg 1.9.2p1 and herwigpp 2.7.1 |
|
please test with cms-sw/cmsdist#20597 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Ignoring test request. |
|
please test with cms-sw/cmsdist#3437 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 5e72235 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h: In instantiation of 'ThePEG::Pointer::RCPtr& ThePEG::Pointer::RCPtr::create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]':
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:126:22: required from 'static ThePEG::Pointer::RCPtr ThePEG::Pointer::RCPtr::Create(ThePEG::Pointer::RCPtr::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::RCPtr::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:869:69: required from 'static ThePEG::Pointer::PtrTraits >::pointer ThePEG::Pointer::PtrTraits >::create(ThePEG::Pointer::PtrTraits >::const_reference) [with T = ThePEG::LesHouchesInterface; ThePEG::Pointer::PtrTraits >::pointer = ThePEG::Pointer::RCPtr; ThePEG::Pointer::PtrTraits >::const_reference = const ThePEG::LesHouchesInterface&]'
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/PtrTraits.h:204:55: required from 'typename ThePEG::Pointer::Ptr::pointer ThePEG::Pointer::new_ptr(const T&) [with T = ThePEG::LesHouchesInterface; typename ThePEG::Pointer::Ptr::pointer = ThePEG::Pointer::RCPtr]'
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-20-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:38:53: required from here
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:147:9: error: invalid new-expression of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-20-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:30:7: note: because the following virtual functions are pure within 'ThePEG::LesHouchesInterface':
class LesHouchesInterface : public LesHouchesReader {
^
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-20-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGHadronizer.cc
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-20-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-20-2300/src/GeneratorInterface/ThePEGInterface/plugins/ThePEGLesHouchesInterface.cc:10:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Interface/ClassDocumentation.h:13:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Config/ThePEG.h:23:
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:147:15: error: allocating an object of abstract class type 'ThePEG::LesHouchesInterface'
ptr = new T(t);
^
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/external/thepeg/2.0.4-njopjo2/include/ThePEG/Pointer/RCPtr.h:126:14: note: in instantiation of member function 'ThePEG::Pointer::RCPtr::create' requested here
return p.create(t);
^
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test with cms-sw/cmsdist#3437 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
needed for the jet energy calibration. since 92x is the branch where the calibration is done.
needs externals: thepeg and herwigpp