Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in HCAL TP LUTs #20610

Merged
merged 3 commits into from Oct 5, 2017

Conversation

akhukhun
Copy link
Contributor

@akhukhun akhukhun commented Sep 21, 2017

backport of #20602
The PR includes the following changes:

  • use average adc2fC over four CapId's instead of the first one to calculate linearization LUTs.
    This has a small effect on TPs.
  • pass HF FG bit threshold through the input LUTs as it's done online
  • small cleanup to remove extra LUT arrays.

It is needed for online DQM to fix the data-emulation mismatches.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2017

A new Pull Request was created by @akhukhun for CMSSW_9_2_X.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mulhearn, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Sep 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23221/console Started: 2017/09/25 22:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20610/23221/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904592
  • DQMHistoTests: Total failures: 45667
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1858751
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Sep 29, 2017

+1

@rekovic
Copy link
Contributor

rekovic commented Oct 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Oct 3, 2017

backport of #20602

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f5667ff into cms-sw:CMSSW_9_2_X Oct 5, 2017
@akhukhun akhukhun deleted the lutAverageAdc2Fc_92X branch February 22, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants