dqm for triplemuon_5_3_3_dz in master br. #20635
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @gkaratha for master. It involves the following packages: DQMOffline/Trigger @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| //compute inv mass of two different leptons | ||
| mumu_mass=(muons[idx2].p4() + muons[idx2].p4()).M(); | ||
| if (mumu_mass<invMassLowercut_ || mumu_mass>invMassUppercut_) allpairs=true; | ||
| } |
There was a problem hiding this comment.
please please indent your code
this is confusing and unreadable
| verbose = cms.untracked.uint32(0), # Set to 2 for all messages | ||
| resolution = cms.vstring(), | ||
| efficiency = cms.vstring( | ||
| "effic_muPt_1 'efficiency vs muon pt; muon pt [GeV]; efficiency' muPt_1_numerator muPt_1_variableBinning_denominator", |
There was a problem hiding this comment.
Hi @dmitrijus ,
Ok fixed thanks
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #20635 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@davidlange6 @dmitrijus |
|
merge |
Dear @mtosi @davidlange6 ,
I did the changes that were asked. And also the PR in master branch as well. Now there is one PR in master, one in 9_3_X and one in 9_2_X(backport of 9_3_X). For any other comment i am at your disposal. Thanks.
Best,
george