[92x] l1t Muon Unpacker Zero Suppression and DQM. Clang cleaning.

[rekovic]

PR 92x - Upgrade the Muon Unpacker and DQM to intelligently handle Zero Suppression, making it BX aware. Also includes CLANG cleaning

Needed for data taking and available in the release at P5 before hardware change goes online (soon).

This is compatible with past, current, and future data.

[cmsbuild]

A new Pull Request was created by @rekovic for CMSSW_9_2_X.

It involves the following packages:

DQM/L1TMonitor
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @kreczko, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from [94x] l1t Muon Unpacker Zero Suppression and DQM. Clang cleaning. #20634

[thomreis]

@dmitrijus @vanbesien could you check this please? The 94x version is merged already and we need it at P5 and the T0 for the new zero suppression.

[rekovic]

@dmitrijus please sign.
After merging, we neet to request a CMSSW release to deploy at P0.

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23456/console Started: 2017/10/05 10:34

[cmsbuild]

+1
Tested at: d5a8b58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20636/23456/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
097c517
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20636/23456/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20636/23456/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20636/23456/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1966593
• DQMHistoTests: Total failures: 15037
• DQMHistoTests: Total nulls: 81
• DQMHistoTests: Total successes: 1951303
• DQMHistoTests: Total skipped: 172
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 9 edm output root files, 23 DQM output files

[davidlange6]

merge