CTPPS pixel clusterizer: call calibration by reference and use of map instead of set

[fabferro]

Removing a copy in the call to gain calibration and use of map instead of set to speed up execution

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20642/938

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20642/938/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20642/938/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[slava77]

since we started touching this,
there is another place where CPU use could be reduced:
https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_9_4_X_2017-09-24-0000-sign962.294736.reCTPPS.pp/162
points to very high cost of iterating over calib_rpix_digi_set_.
If the set can be changed to a map with a key column*maxRow+row, lookup should be much easier than a linear scan over the full set every time a pixel is needed.
another alternative is to fill a vector size maxRow*maxCol, but this is perhaps too costly on low occupancy.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20642/939

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

RecoCTPPS/PixelLocal

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20642/961

[fabferro]

@slava77 I've implemented the use of map instead of set. Please check at your convinience that this speeds up execution.

[cmsbuild]

Pull request #20642 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23421/console Started: 2017/10/04 09:47

[cmsbuild]

+1
Tested at: b7fe46b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20642/23421/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
575a47c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20642/23421/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20642/23421/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20642/23421/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2761357
• DQMHistoTests: Total failures: 253
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2760917
• DQMHistoTests: Total skipped: 187
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[slava77]

+1

for #20642 b7fe46b

• technical update since the last signoff by reco https://github.com/cms-sw/cmssw/pull/20642/files/284575feb45b3521371d64ff9597d3c487655333..b7fe46b741a7f645c65325ca7db3007ba704bd31
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1

[slava77]

@fabferro
please update the PR title and description to reflect what is done in the PR