add LumiCorrections records and definitions; adding LumiInfo.h members/methods #20651
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @capalmer85 for master. It involves the following packages: CondCore/LuminosityPlugins @perrotta, @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @ggovi, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Attn @samhiggie, @plujan |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 854e135 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: plugin.cc:(.text._ZN16DataProxyWrapperI18LumiSectionDataRcdN4lumi15LumiSectionDataEN4cond18DefaultInitializerIS2_EEEC2ERNS3_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESH_PKc[_ZN16DataProxyWrapperI18LumiSectionDataRcdN4lumi15LumiSectionDataEN4cond18DefaultInitializerIS2_EEEC5ERNS3_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESH_PKc]+0x20d): undefined reference to `char const* edm::typelookup::className()' plugin.cc:(.text._ZN16DataProxyWrapperI18LumiSectionDataRcdN4lumi15LumiSectionDataEN4cond18DefaultInitializerIS2_EEEC2ERNS3_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESH_PKc[_ZN16DataProxyWrapperI18LumiSectionDataRcdN4lumi15LumiSectionDataEN4cond18DefaultInitializerIS2_EEEC5ERNS3_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESH_PKc]+0x215): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' tmp/slc6_amd64_gcc630/src/CondCore/LuminosityPlugins/src/CondCoreLuminosityPlugins/plugin.o: In function `DataProxyWrapper >::DataProxyWrapper(cond::persistency::Session&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, char const*)': plugin.cc:(.text._ZN16DataProxyWrapperI18LumiCorrectionsRcd15LumiCorrectionsN4cond18DefaultInitializerIS1_EEEC2ERNS2_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESG_PKc[_ZN16DataProxyWrapperI18LumiCorrectionsRcd15LumiCorrectionsN4cond18DefaultInitializerIS1_EEEC5ERNS2_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESG_PKc]+0x20d): undefined reference to `char const* edm::typelookup::className()' plugin.cc:(.text._ZN16DataProxyWrapperI18LumiCorrectionsRcd15LumiCorrectionsN4cond18DefaultInitializerIS1_EEEC2ERNS2_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESG_PKc[_ZN16DataProxyWrapperI18LumiCorrectionsRcd15LumiCorrectionsN4cond18DefaultInitializerIS1_EEEC5ERNS2_11persistency7SessionERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESG_PKc]+0x215): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc6_amd64_gcc630/src/CondCore/LuminosityPlugins/src/CondCoreLuminosityPlugins/libCondCoreLuminosityPlugins.so] Error 1 Leaving library rule at CondCore/LuminosityPlugins >> Leaving Package CondCore/LuminosityPlugins >> Package CondCore/LuminosityPlugins built >> Subsystem CondCore built The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
hmmm... that certainly doesn't happen when I do "scram b" locally. Is
there a particular build if CMSSW I should be working on top of?
…On Mon, Sep 25, 2017 at 3:20 PM, cmsbuild ***@***.***> wrote:
Comparison not run due to Build errors (RelVals and Igprof tests were also
skipped)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20651 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFKqhy6F0dHLan3duahiwGMGr6Z-PVWbks5sl_0MgaJpZM4PjK-S>
.
|
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
| @@ -6,4 +6,5 @@ | |||
| <class name="std::vector< lumi::HLTInfo >"/> | |||
| <class name="std::vector< lumi::TriggerInfo >"/> | |||
| <class name="std::vector< lumi::BunchCrossingInfo >"/> | |||
| <class name="LumiCorrections" class_version="0"/> | |||
There was a problem hiding this comment.
the class version is no longer needed for the persistency since ORA disappeared ( cmssw_7_2_X )
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
This is for 94X. @arunhep suggested making these changes ahead of a PR for adding modules to be run at PCL because the record has to be in 94X.