Sped up principal 'put' #20661
Merged
Sped up principal 'put' #20661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added move constructor and move assignment operations.
Use move to deal with BranchID and ParentageID.
If a destructor is defined, the compiler is not allowed to generate a move constructor or move assignment.
Only ProducerSourceBase needs the ProductRegistryHelper functionality (it actually better to use ProducerBase).
Keep track of the need to record parentage for a product at the call to produces. This will help simplify the Event::put call.
Keep track of the ProductResolverIndex for each EDPutToken and use the index directly. The decision to keep the parentage is now determined at initialization time, not Event::put time.
Instead of calculating the ProductID from the BranchID, get the ProductID cached by the ProductResolver.
Avoided unnecessary synchronization and gave hints to the compiler about the likelihood of dealing with an exception.
Knowing the number of products to be consumed helps reserve space.
As data is being gotten from the Event, check to see if it was recorded in the parentage cache. If not, add to the extra container. If all items were obtained from the parentage cache and no new ones were added, use the cached parentageID.
Extended the number of cases that will cause an exception to be thrown if there is a problem with Event::put. Also have Event::put using EDGetTokens directly use the index.
Use the typedef instead of the value type in order to help future maintenance.
Check that the type used in Event::put when using EDPutToken is what was expected.
Change Event::getRefBeforePut to use the same new infrastructure as Event::put.
We need to setup the Principal for the end transition before calling the source.
The interfaces using LuminosityBlock and Run will now only work properly if the class inherits from ProducerBase. Therefore these were moved to ProducerSourceBase and the relevant 'do' methods were made virtual. Also made ProducerSourceBase a friend of ProducerBase to allow it to call commit_.
Run and LuminosityBlock now use EDPutToken indices to implement 'put'.
Created the PuttableSourceBase class to separate the handling of the 'produces' and 'put' interface from ProducerSourceBase. This allows sharing of the implementation with other sources that do not want to use ProducerSourceBase's transition handling implementation.
The 'produces' and 'put' interfaces where removed from InputSource and put into PuttableSourceBase. This change updates DQMProtobufReader to follow the change.
|
Pull request #20661 was updated. @ghellwig, @cerminar, @rekovic, @vanbesien, @govoni, @perrotta, @civanch, @monttj, @cmsbuild, @smuzaffar, @Dr15Jones, @mdhildreth, @slava77, @mulhearn, @efeyazgan, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @thuer, @dmitrijus, @franzoni, @lpernie can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
+1 |
|
+1
|
|
merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sped up the time it takes to 'put' data into the Event, LuminosityBlock and Run.
Using a configuration with the same topology as the HLT but with trivial modules, the code makes that configuration run 20% faster.