StallMonitor handles case where module does not prefetch #20678
Conversation
The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.
|
The code-checks are being triggered in jenkins. |
|
@dan131riley can you try this versions with your work on the output module? |
|
+code-checks |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
Bogus entries are gone and remaining entries look ok:
StallMonitor> Module label # of stalls Total stalled time Max stalled time
StallMonitor> ---------------- ----------- ------------------ ----------------
StallMonitor> MINIAODSIMoutput 9 1.998 s 0.41 s
|
|
@dan131riley thanks! |
|
@dan131riley do the graphs look more reasonable? |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.