fwd-port HTXS to master #20683

perrozzi · 2017-09-28T02:43:22Z

https://twiki.cern.ch/twiki/bin/viewauth/CMS/HiggsTemplateCrossSection
needed to put the HTXS categorization into nanoAOD
@arizzi @gpetruc @dsperka

cmsbuild · 2017-09-28T02:43:42Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-28T02:47:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20683/1021

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20683/1021/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20683/1021/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2017-09-28T02:56:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-28T02:58:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20683/1022

cmsbuild · 2017-09-28T02:58:20Z

A new Pull Request was created by @perrozzi for master.

It involves the following packages:

GeneratorInterface/RivetInterface
SimDataFormats/HTXS

The following packages do not have a category, yet:

SimDataFormats/HTXS
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

Backported from (fwd-port) HTXS to master #21490

perrozzi · 2017-09-28T02:59:42Z

please test

cmsbuild · 2017-09-28T03:00:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23283/console Started: 2017/09/28 05:24

cmsbuild · 2017-09-28T03:29:52Z

-1

Tested at: d70aa5c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
897a3cf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/23283/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/23283/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/23283/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverterHTXS.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/MergedGenParticleProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverterHTXS.cc: In member function 'virtual void GenParticles2HepMCConverterHTXS::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverterHTXS.cc:228:39: error: no matching function for call to 'edm::Event::put(std::auto_ptr&, const char [10])'
   event.put(hepmc_product, "unsmeared");
                                       ^
In file included from /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-09-27-2300/src/FWCore/Framework/interface/stream/ProducingModuleAdaptorBase.h:36:0,
                 from /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-09-27-2300/src/FWCore/Framework/interface/stream/EDProducerAdaptorBase.h:24,
                 from /cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-09-27-2300/src/FWCore/Framework/interface/stream/EDProducerAdaptor.h:24,

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/src/CMS_2013_I1224539_DIJET.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/src/HiggsTemplateCrossSections.cc 
Selected class -> HTXS::HiggsClassification for ROOT: HTXS::HiggsClassification
Selected class -> edm::Wrapper for ROOT: edm::Wrapper
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc630/src/SimDataFormats/HTXS/src/SimDataFormatsHTXS/a/SimDataFormatsHTXS_xr.cc
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-27-2300/src/GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverterHTXS.cc:228:9: error: no matching member function for call to 'put'
  event.put(hepmc_product, "unsmeared");
  ~~~~~~^~~
/cvmfs/cms-ib.cern.ch/nweek-02491/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_4_X_2017-09-27-2300/src/FWCore/Framework/interface/Event.h:380:10: note: candidate template ignored: could not match 'unique_ptr' against 'auto_ptr'
  Event::put(std::unique_ptr product, std::string const& productInstanceName) {
         ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
897a3cf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/23283/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/23283/git-merge-result

cmsbuild · 2017-09-28T03:29:54Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-10-30T18:02:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24057/console Started: 2017/10/30 19:03

cmsbuild · 2017-10-30T20:13:54Z

+1
Tested at: 4c78dce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/24057/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e099e08
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/24057/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/24057/git-merge-result

cmsbuild · 2017-10-30T20:13:57Z

Comparison job queued.

cmsbuild · 2017-10-30T21:48:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20683/24057/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2838442
DQMHistoTests: Total failures: 117
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2838154
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

perrozzi · 2017-10-31T06:01:34Z

+1

arizzi · 2017-11-03T11:05:14Z

@davidlange6 will this be taken for 940?

arizzi · 2017-11-16T15:41:29Z

what's the fate of this PR? Can it be included in a 94x release? (if so, @perrozzi I guess you need to make a new PR against 94X branch)

perrozzi · 2017-11-16T16:54:42Z

I am waiting for it to be merged... then sure I can do the backport

arizzi · 2017-11-21T15:00:04Z

@perrozzi I think you only need to open the PR :
CMSSW_9_4_X...perrozzi:htxs_master

as the very same branch is mergeable on 94X too

gpetruc · 2017-12-01T10:14:51Z

I think it's the other way around, i.e. #21490 is the backport of this PR, since this PR is for master while #21490 is for 9_4_X

cmsbuild · 2017-12-01T10:15:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-12-01T16:01:42Z

merge

davidlange6 · 2017-12-01T16:02:01Z

sorry that it took some extra time to come back to this one

fwd-port HTXS to master

c2f872c

cmsbuild added this to the CMSSW_9_4_X milestone Sep 28, 2017

cmsbuild added code-checks-pending comparison-pending generators-pending new-package-pending orp-pending pending-signatures tests-pending labels Sep 28, 2017

perrozzi mentioned this pull request Sep 28, 2017

Higgs simplified analysis cms-nanoAOD/cmssw#9

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 28, 2017

apply code-checks

d70aa5c

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 28, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2017

cmsbuild removed comparison-pending tests-started labels Sep 28, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2017

cmsbuild added generators-approved and removed generators-pending labels Oct 31, 2017

cmsbuild added the backport label Nov 30, 2017

cmsbuild removed the new-package-pending label Dec 1, 2017

cmsbuild added fully-signed and removed pending-signatures labels Dec 1, 2017

perrozzi mentioned this pull request Dec 1, 2017

(fwd-port) HTXS to master #21490

Merged

cmsbuild added orp-approved and removed backport orp-pending labels Dec 1, 2017

cmsbuild merged commit e2a792f into cms-sw:master Dec 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fwd-port HTXS to master #20683

fwd-port HTXS to master #20683

perrozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 •

edited

perrozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Oct 30, 2017 •

edited

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrozzi commented Oct 31, 2017

arizzi commented Nov 3, 2017

arizzi commented Nov 16, 2017

perrozzi commented Nov 16, 2017

arizzi commented Nov 21, 2017

gpetruc commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

davidlange6 commented Dec 1, 2017

davidlange6 commented Dec 1, 2017

fwd-port HTXS to master #20683

fwd-port HTXS to master #20683

Conversation

perrozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 • edited

perrozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 • edited

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Oct 30, 2017 • edited

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrozzi commented Oct 31, 2017

arizzi commented Nov 3, 2017

arizzi commented Nov 16, 2017

perrozzi commented Nov 16, 2017

arizzi commented Nov 21, 2017

gpetruc commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

davidlange6 commented Dec 1, 2017

davidlange6 commented Dec 1, 2017

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Sep 28, 2017 •

edited

cmsbuild commented Oct 30, 2017 •

edited