Update to the ZMuSkim #20693

rvenditti · 2017-09-28T16:07:30Z

Change the ZMuSkim defintion in order to meet the need of Muons subsystems DPGs.
Main changes wrt to previous version are:
-definition of the "loose" leg to be an isolated track (not a muon as in the previous skim definition)
-apply tight muon ID on the "tight" leg and increase the value of the cut on pT
-apply additional selections on the dimuon candidate (on the dz(loose leg, tight leg), OS)

New selections have been presented (and blessed) in the muon pog meeting:
https://indico.cern.ch/event/666069/contributions/2722477/attachments/1525026/2384260/ZMUskim_CSC_proposal_Sep18.pdf

cmsbuild · 2017-09-28T16:07:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-28T16:14:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20693/1037

cmsbuild · 2017-09-28T16:15:15Z

A new Pull Request was created by @rvenditti for master.

It involves the following packages:

DPGAnalysis/Skims

@cmsbuild, @kkousour, @GurpreetSinghChahal, @fabozzi can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

fabozzi · 2017-09-28T16:24:02Z

please test workflow 136.730,136.787

cmsbuild · 2017-09-28T16:24:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23309/console Started: 2017/09/28 18:58

cmsbuild · 2017-09-28T18:08:49Z

+1
Tested at: 0805966
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23309/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
030352c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23309/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23309/git-merge-result

cmsbuild · 2017-09-28T18:08:52Z

Comparison job queued.

drkovalskyi · 2017-09-29T12:18:11Z

This skim is not tested by Muon POG to satisfy the requirements that we agreed on. Please hold integration until we confirm that it's Ok to proceed.

drkovalskyi · 2017-10-01T17:49:03Z

This skim is not tested by Muon POG to satisfy the requirements that we agreed on. Please hold integration until we confirm that it's Ok to proceed.

I have checked the implementation and found it reasonable. The rate of the new skim is equal to the rate of current skim. Please proceed with integration of the change.

fabozzi · 2017-10-02T07:38:04Z

+1

cmsbuild · 2017-10-02T07:38:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-10-03T18:10:47Z

DPGAnalysis/Skims/python/ZMuSkim_cff.py

@@ -1,44 +1,166 @@
 import FWCore.ParameterSet.Config as cms
-
+from Configuration.StandardSequences.MagneticField_cff import *


hi @rvenditti - the magnetic field is set at a much higher level than within a skim. Please remove this.

fabozzi · 2017-10-04T09:08:48Z

please test workflow 136.730,136.787

cmsbuild · 2017-10-04T09:09:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23432/console Started: 2017/10/04 11:09

cmsbuild · 2017-10-04T11:21:06Z

+1
Tested at: 1e92554
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23432/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
575a47c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23432/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23432/git-merge-result

cmsbuild · 2017-10-04T11:21:08Z

Comparison job queued.

cmsbuild · 2017-10-04T13:07:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20693/23432/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2761357
DQMHistoTests: Total failures: 252
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2760918
DQMHistoTests: Total skipped: 187
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

fabozzi · 2017-10-04T13:42:44Z

+1

cmsbuild · 2017-10-04T13:43:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-10-10T11:09:40Z

+1

Dr15Jones · 2017-10-11T00:14:09Z

This appears to have broken step3 of workflow 1000.0 with the error

----- Begin Fatal Exception 11-Oct-2017 01:03:43 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PATMuonProducer label='tightMuonsCandidateForZMuSkim'
Exception Message:
MissingParameter: Parameter 'recomputeBasicSelectors' not found.
----- End Fatal Exception -------------------------------------------------

slava77 · 2017-10-11T13:31:47Z

DPGAnalysis/Skims/python/ZMuSkim_cff.py

+
+
+###create the "tag collection" of muon candidate, embedding the relevant infos  
+tightMuonsCandidateForZMuSkim = cms.EDProducer("PATMuonProducer",


this has to be cloned and modified from a default config

@gpetruc
you noticed this issue in #20887

slava77 · 2017-10-11T13:32:51Z

looks like an example of merging based on obsolete test results.

rvenditti · 2017-10-11T14:16:03Z

I have updated my branch, do you want me to open a new PR?
https://github.com/rvenditti/cmssw/blob/ZMuSkim-2017update-CSCProposal/DPGAnalysis/Skims/python/ZMuSkim_cff.py

davidlange6 · 2017-10-11T16:17:41Z

hi @rvenditti - yes please make a new PR. Thanks.

davidlange6 · 2017-10-11T19:34:13Z

i realized that I could do it - #20741.

Update ZMuSkim using CSC proposal-DR cut removed

0805966

cmsbuild added this to the CMSSW_9_4_X milestone Sep 28, 2017

cmsbuild added code-checks-pending comparison-pending orp-pending pdmv-pending pending-signatures tests-pending labels Sep 28, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2017

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2017

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Oct 2, 2017

davidlange6 reviewed Oct 3, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 4, 2017

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Oct 4, 2017

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2017

cmsbuild merged commit a2aeaf0 into cms-sw:master Oct 10, 2017

slava77 reviewed Oct 11, 2017

View reviewed changes

slava77 mentioned this pull request Oct 11, 2017

Support Comp2RefEqualH DQM quality test also on TProfile #20887

Merged

perrotta mentioned this pull request Oct 11, 2017

Protect against missing track info in MiniAOD #20741

Merged

marco-link mentioned this pull request Oct 12, 2017

Add Mjj and Softdrop monitor to OfflineDQM for B2G analysis #20882

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to the ZMuSkim #20693

Update to the ZMuSkim #20693

rvenditti commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

fabozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 •

edited

Loading

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

drkovalskyi commented Sep 29, 2017

drkovalskyi commented Oct 1, 2017

fabozzi commented Oct 2, 2017

cmsbuild commented Oct 2, 2017

davidlange6 Oct 3, 2017

fabozzi commented Oct 4, 2017

cmsbuild commented Oct 4, 2017 •

edited

Loading

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

fabozzi commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

davidlange6 commented Oct 10, 2017

Dr15Jones commented Oct 11, 2017

slava77 Oct 11, 2017

slava77 commented Oct 11, 2017

rvenditti commented Oct 11, 2017

davidlange6 commented Oct 11, 2017

davidlange6 commented Oct 11, 2017

		@@ -1,44 +1,166 @@
		import FWCore.ParameterSet.Config as cms

		from Configuration.StandardSequences.MagneticField_cff import *



		###create the "tag collection" of muon candidate, embedding the relevant infos
		tightMuonsCandidateForZMuSkim = cms.EDProducer("PATMuonProducer",

Update to the ZMuSkim #20693

Update to the ZMuSkim #20693

Conversation

rvenditti commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

fabozzi commented Sep 28, 2017

cmsbuild commented Sep 28, 2017 • edited Loading

cmsbuild commented Sep 28, 2017

cmsbuild commented Sep 28, 2017

drkovalskyi commented Sep 29, 2017

drkovalskyi commented Oct 1, 2017

fabozzi commented Oct 2, 2017

cmsbuild commented Oct 2, 2017

davidlange6 Oct 3, 2017

Choose a reason for hiding this comment

fabozzi commented Oct 4, 2017

cmsbuild commented Oct 4, 2017 • edited Loading

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

fabozzi commented Oct 4, 2017

cmsbuild commented Oct 4, 2017

davidlange6 commented Oct 10, 2017

Dr15Jones commented Oct 11, 2017

slava77 Oct 11, 2017

Choose a reason for hiding this comment

slava77 commented Oct 11, 2017

rvenditti commented Oct 11, 2017

davidlange6 commented Oct 11, 2017

davidlange6 commented Oct 11, 2017

cmsbuild commented Sep 28, 2017 •

edited

Loading

cmsbuild commented Oct 4, 2017 •

edited

Loading