Support Comp2RefEqualH DQM quality test also on TProfile

[gpetruc]

As the title reads, plus scram code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20887/1363

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

DQMServices/Core

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23670/console Started: 2017/10/11 12:03

[cmsbuild]

-1

Tested at: d1622f6

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23670/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23670/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23670/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step3

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dd401df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23670/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23670/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[gpetruc]

Uhm, the error in 1000.0 is

----- Begin Fatal Exception 11-Oct-2017 13:00:49 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PATMuonProducer label='tightMuonsCandidateForZMuSkim'
Exception Message:
MissingParameter: Parameter 'recomputeBasicSelectors' not found.
----- End Fatal Exception -------------------------------------------------

which IMHO comes from #20612 (merged) breaking DPGAnalysis/Skims/python/ZMuSkim_cff.py since that cff file makes a PATMuonProducer explicitly, and misses the new required parameter recomputeBasicSelectors (the parameter also seems to be missing in the PATMuonProducer fillDescriptions, but apparently parameter set validation is disabled for that class since 2009 by bd44959 so the ~100 lines of implementation don't do anything)

[slava77]

On 10/11/17 6:21 AM, Giovanni Petrucciani wrote: |MissingParameter: Parameter 'recomputeBasicSelectors' not found. ----- End Fatal Exception ------------------------------------------------- | which IMHO comes from #20612 <#20612> (merged) breaking DPGAnalysis/Skims/python/ZMuSkim_cff.py <https://github.com/cms-sw/cmssw/blob/master/DPGAnalysis/Skims/python/ZMuSkim_cff.py> since that cff file makes a |PATMuonProducer| explicitly, and misses the new required parameter |recomputeBasicSelectors| (the parameter also seems to be missing in the |PATMuonProducer| fillDescriptions <https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc#L638-L745>, but apparently parameter set validation is disabled for that class since 2009 by bd44959 <bd44959> so the ~100 lines of implementation don't do anything)

to preserve formal causality: the DPGAnalysis/Skims/python/ZMuSkim_cff.py was updated in #20693 merged ~26 hrs ago while the #20612 was merged 3 days ago.

[gpetruc]

rerunning the tests as the IB should now be working

[gpetruc]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23727/console Started: 2017/10/12 16:37

[cmsbuild]

+1
Tested at: d1622f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23727/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
561fe85
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23727/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23727/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20887/23727/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2767051
• DQMHistoTests: Total failures: 111
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2766769
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1