New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PU vs LS #20694
add PU vs LS #20694
Conversation
fix
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20694/1039 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20694/1039/git-diff.patch You can run |
Please apply the flagged code changes both here and in the 92X backport PR. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: DQM/HLTEvF @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @Martin-Grunewald, @silviodonato, @fwyzard, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks |
Pull request #20694 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @Martin-Grunewald, @silviodonato, @fwyzard, @vanbesien can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
it is generally run by HLT job in p5 and by the DQMOffline_Trigger_cff
while testing this code,
I realized there was a message in the DQM step about a module (
muonsPt10
) I recentely added,and I fixed that issue as well