Ecal bad calib filter #20698

dvannerom · 2017-09-29T14:54:24Z

Pull Request to add the EcalBadCalibFilter in the standard filters sequence

cmsbuild · 2017-09-29T14:54:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-29T14:58:13Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1051

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1051/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1051/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

cmsbuild · 2017-09-29T15:16:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-29T15:18:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-29T15:18:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1054

cmsbuild · 2017-09-29T15:18:55Z

A new Pull Request was created by @dvannerom for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoMET/METFilters

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-09-29T15:19:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1055

slava77 · 2017-09-29T15:23:39Z

@cmsbuild please test

cmsbuild · 2017-09-29T15:24:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23330/console Started: 2017/09/29 17:24

slava77 · 2017-09-29T17:03:23Z

RecoMET/METFilters/plugins/EcalBadCalibFilter.cc

+      std::cout << "Detid=" << eedet.rawId() 
+      << " ix=" << ix << " iy=" << iy<< " iz=" << iz 
+      << " energy=" << ene << " et=" << et << std::endl;
+    */


is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

this applies to all of this PR

cmsbuild · 2017-10-27T08:18:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-10-27T08:20:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20698/1670

cmsbuild · 2017-10-27T08:23:13Z

Pull request #20698 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

slava77 · 2017-10-27T08:35:25Z

@cmsbuild please test

cmsbuild · 2017-10-27T08:35:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24009/console Started: 2017/10/27 10:40

cmsbuild · 2017-10-27T10:34:53Z

+1
Tested at: 47fd4b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20698/24009/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20698/24009/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20698/24009/git-merge-result

cmsbuild · 2017-10-27T10:34:55Z

Comparison job queued.

cmsbuild · 2017-10-27T16:23:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20698/24009/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2786851
DQMHistoTests: Total failures: 121
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2786558
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

slava77 · 2017-10-28T04:35:42Z

+1

for #20698 47fd4b9

ecalBadCalibFilter to be used for run2 processing.
jenkins tests pass
local tests with MC 10224 and data from JetHT run 302651 prompt AOD show that the filter is running at negligible cost in CPU. The selection rate in MC is below O(1-3) [0 events in 3K test], and around 0.2% in JetHT data [8/5000 selected]

I think that it should be safe to add this to 94X.
@dvannerom @gouskos please prepare a backport PR to 94X if you need this filter in 94X.

gouskos · 2017-10-28T06:19:35Z

Thank you @slava77 Yes we need it in 94X - we will prepare it today

gouskos · 2017-10-28T15:33:50Z

Hi @slava77 We created #21061 using the latest 94X IB but I see that the milestone is set again for CMSSW_10_0_X. Can you please advice how we should backport it ? Thank you.

perrotta · 2017-10-28T15:53:57Z

@gouskos : when you submit your pull request, set the base as 9_4_X, instead of keeping the default (which is always master)

gouskos · 2017-10-28T15:58:34Z

@perrotta Oh - yes - I am sorry . I am doing it now. So we can close the previous PR or I can change it on the fly ?

gouskos · 2017-10-28T16:04:28Z

Hi @perrotta @slava77 please find here the correct PR (#21062) to backport the EcalBadCalib filter in 94X.

davidlange6 · 2017-10-29T07:24:48Z

merge

dvannerom added 2 commits September 28, 2017 21:23

ffff

2334729

Adding EcalBadCalibFilter to MET filters sequence

f66b9d3

cmsbuild added this to the CMSSW_9_4_X milestone Sep 29, 2017

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 29, 2017

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 29, 2017

Update EcalBadCalibFilter.cc

42c7d41

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 29, 2017

Update EcalBadCalibFilter.cc

b517af2

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 29, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2017

slava77 reviewed Sep 29, 2017

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 27, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 27, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 27, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 28, 2017

gouskos mentioned this pull request Oct 28, 2017

ECAL Bad Calibration Filter for 94X #21061

Closed

gouskos mentioned this pull request Oct 28, 2017

ECAL Bad Calibration Filter for 94X #21062

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 29, 2017

cmsbuild merged commit e2c95d1 into cms-sw:master Oct 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ecal bad calib filter #20698

Ecal bad calib filter #20698

dvannerom commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

slava77 commented Sep 29, 2017

cmsbuild commented Sep 29, 2017 •

edited

Loading

slava77 Sep 29, 2017

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

slava77 commented Oct 27, 2017

cmsbuild commented Oct 27, 2017 •

edited

Loading

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

slava77 commented Oct 28, 2017

gouskos commented Oct 28, 2017

gouskos commented Oct 28, 2017

perrotta commented Oct 28, 2017

gouskos commented Oct 28, 2017

gouskos commented Oct 28, 2017

davidlange6 commented Oct 29, 2017

Ecal bad calib filter #20698

Ecal bad calib filter #20698

Conversation

dvannerom commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

cmsbuild commented Sep 29, 2017

slava77 commented Sep 29, 2017

cmsbuild commented Sep 29, 2017 • edited Loading

slava77 Sep 29, 2017

Choose a reason for hiding this comment

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

slava77 commented Oct 27, 2017

cmsbuild commented Oct 27, 2017 • edited Loading

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

cmsbuild commented Oct 27, 2017

slava77 commented Oct 28, 2017

gouskos commented Oct 28, 2017

gouskos commented Oct 28, 2017

perrotta commented Oct 28, 2017

gouskos commented Oct 28, 2017

gouskos commented Oct 28, 2017

davidlange6 commented Oct 29, 2017

cmsbuild commented Sep 29, 2017 •

edited

Loading

cmsbuild commented Oct 27, 2017 •

edited

Loading