Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL Bad Calibration Filter for 94X #21062

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

gouskos
Copy link
Contributor

@gouskos gouskos commented Oct 28, 2017

Backporting #20698 in 94X: Add a filter for the Ecal crystal with bad calibrations

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2017

A new Pull Request was created by @gouskos for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoMET/METFilters

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@gouskos gouskos mentioned this pull request Oct 28, 2017
@slava77
Copy link
Contributor

slava77 commented Oct 28, 2017

backport of #20698

@slava77
Copy link
Contributor

slava77 commented Oct 28, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24032/console Started: 2017/10/28 18:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21062/24032/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2838160
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 30, 2017

+1

for #21062 681792e

  • addition of a MET filter path to flag events if some ecal channels are over threshold; backport of Ecal bad calib filter #20698 is correct
  • jenkins tests pass and comparisons show no difference

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7778833 into cms-sw:CMSSW_9_4_X Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants