Enable usage of TTreeCache in Fireworks #20702
Conversation
Port from 9.2.7 to 9.4.0. See cms-sw#20118 for discussion.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20702/1061 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20702/1061/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @osschar (Matevž Tadel) for master. It involves the following packages: DataFormats/FWLite @cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
visualization-approved
and removed
core-pending
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
| if (FWTTreeCache::IsLogging()) | ||
| printf("FWFileEntry::openFile enabling FWTTreeCache for file class '%s'.", m_file->ClassName()); | ||
|
|
||
| auto tc = new FWTTreeCache(m_eventTree, FWTTreeCache::GetDefaultCacheSize()); |
There was a problem hiding this comment.
hi @osschar - is this pointer cleaned up somewhere?
|
Yes, ownership is transferred to TFile on the next line, 122. |
|
+1 |
Port from 9.2.7 to 9.4.0. See #20118 for discussion.