Extract timing for tracker-only muons #20705
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20705/1070 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20705/1070/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @drkovalskyi for master. It involves the following packages: RecoMuon/MuonIdentification @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
I see some segfaults that seem to be related to the changes. Will investigate. |
Seems to be false positive. Rerunning the matrix to confirm. It's all good. |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Adding arbitration allows a few extra muons getting correct timing info: below the same figures that were obtained before the last commit are taken with that latest addition for comparison
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
I could not understand which of the 5 plots below can be compared with what is "before the last commit". |
|
Good catch Slava: indeed I did not remember that I used slimmed photons for the previous 2012B and 2017B figures instead of reco ones. Adjusted now in my last entry: you can see that the 2012B figures have now the same number of events in both figures. |
|
Ok, I got it, Different events were used for the two IBs, due to #20699 merged in the meanwhile |
|
+1 |
Modified CSC/DT timing extraction code to handle cases of tracker-only muons. Timing distributions will change since muons that didn't have timing computed before will not have non-zero values. Many fake TrackerMuons have wrong timing, so having significant deviations from zero timing is expected. It's a critical development for high-pileup fake suppression. Needed for 94X.