FastTimerServiceClient bug fix #20726
Conversation
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild, please test |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: HLTrigger/Timer @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@mtosi |
|
I included it in the PR #20695
I hope it is fine
…On Tue, Oct 3, 2017 at 11:12 AM, Martin Grunewald ***@***.***> wrote:
@mtosi <https://github.com/mtosi>
92X backport needed as well...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20726 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58ziDtde7mvH1K3gnTYDvGeQFkiCaks5sofqRgaJpZM4Pryp5>
.
|
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
| double ymin = me->getTProfile()->GetMinimum(); | ||
| double ymax = me->getTProfile()->GetMaximum(); | ||
| float ymin = 0.; | ||
| float ymax = std::numeric_limits<float>::max(); |
There was a problem hiding this comment.
hi @mtosi - naively it looks to be better just to drop the ymin and ymax arguments from the bookProfile call below. Why keep them?
|
I tried, but I got compilation errors
because apparently the bookProfile methods do not handle such a possibility
https://github.com/mtosi/cmssw/blob/54acd90ac2532e910b2127c565c72ea1f3e76cee/DQMServices/Core/interface/DQMStore.h#L435-L476
mia
…On Thu, Oct 5, 2017 at 9:50 AM, David Lange ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In HLTrigger/Timer/plugins/FastTimerServiceClient.cc
<#20726 (comment)>:
> @@ -418,8 +418,8 @@ FastTimerServiceClient::fillPlotsVsLumi(DQMStore::IBooker & booker, DQMStore::IG
label.erase(label.find("_byls"));
MonitorElement* me = getter.get(current_path + "/" + m);
- double ymin = me->getTProfile()->GetMinimum();
- double ymax = me->getTProfile()->GetMaximum();
+ float ymin = 0.;
+ float ymax = std::numeric_limits<float>::max();
hi @mtosi <https://github.com/mtosi> - naively it looks to be better just
to drop the ymin and ymax arguments from the bookProfile call below. Why
keep them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20726 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEt589aqlw3HP3exCBy7UaIjwDSvb5Uxks5spIo1gaJpZM4Pryp5>
.
|
|
sigh - indeed - maybe @dmitrijus can eventually fix that |
|
+1 |
bug fix
plots vs lumi were empty in runs at the beginning of the fill