New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around inconsistency in ExternalLHEProducer #20730
Work around inconsistency in ExternalLHEProducer #20730
Conversation
The ExternalLHEProducer puts the 'same' data product into the Run at both beginRun and endRun. This is not a behavior the framework was intended to support (and causes sematic problems). However, in order to avoid breaking existing workflows, we must accomodate this behavior for the moment.
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20730/1110 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20730/1110/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
@davidlange6 @smuzaffar this is the fix for the recent IB RelVal failures involving ExternalLHEProducer. |
+code-checks |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi, @thuer, @cmsbuild, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
please test workflow 514.0 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@smuzaffar @davidlange6 the workflow 514.0 ran fine with this change but was failing in the IBs. Looks like the fix worked and doesn't show any signs of any unwanted side-effects. |
merge |
The ExternalLHEProducer puts the 'same' data product into the Run
at both beginRun and endRun. This is not a behavior the framework
was intended to support (and causes sematic problems). However,
in order to avoid breaking existing workflows, we must accomodate
this behavior for the moment.